Repository navigation
feat: async dynamic import() API (v0.18 P1) - #778
Merged
Merged
Conversation
Expose SetDynamicImportHandler/FinishDynamicImport/LoadModuleURL and an opt-in SetDefaultDynamicImport stub, without changing SetModuleImport's legacy sync import() behavior used by ModuleBuilder.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #778 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 17 18 +1
Lines 3262 3421 +159
==========================================
+ Hits 3262 3421 +159
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Exercise goDynamicImport edge cases, FinishDynamicImport error/success hooks, LoadModuleURL attribute checks, and fail-closed pending cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DynamicImportHandler,SetDynamicImportHandler,FinishDynamicImport, andLoadModuleURLfor quickjs-ng v0.18 asyncimport().SetDefaultDynamicImport(qjs-compatible C stub); keepSetModuleImportloader-only so ModuleBuilder virtual modules keep working on the legacy sync path.Schedule+ GoAwait), and fail-closed paths.Test plan
go test ./...